fix(dashboard): extract hardcoded aria-labels to i18n — batch 3#3246
Merged
Conversation
- Replace hardcoded aria-label strings with t('aria.keyName') across 70 files
- Add useT mock to test setup with English catalog resolution + param substitution
- Add missing catalog keys: aria.searchPipelines, pipelines.sortBy
- Fix PipelinesPage: use searchPipelines instead of searchSessions
- Fix test assertions: update static analysis patterns for i18n keys
- Update OverviewPage test mock to resolve from catalog
- TSC clean, 128 test files pass, build green
Refs: #3229
OneStepAt4time
changed the title
OneStepAt4time
force-pushed
the
feat/dashboard-aria-i18n-extract
branch
from
7d24f8b to
812475f
Compare
![aegis-gh-agent[bot]](https://avatars.githubusercontent.com/u/106186915?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Approved — all CI green (helm-smoke flake re-run passed).
Batch 3 completes #3229. 70 component files + 5 test files + 2 catalog files.
Review notes:
- All 70 files follow consistent pattern: aria-label="hardcoded" → aria-label={t("aria.key")}
- Zero hardcoded aria-labels in added lines (grep verified)
- Test setup mock in setup.ts resolves from English catalog with {param} substitution — clean
- New catalog keys: aria.searchPipelines, pipelines.sortBy (en + it)
- Bug fix: PipelinesPage had wrong aria key (searchSessions → searchPipelines)
- 1265 tests pass locally, tsc clean
This closes the full 158-label i18n extraction effort. Three batches shipped cleanly.
Contributor
There was a problem hiding this comment.
✅ Approved — Comprehensive i18n extraction.
What changed:
- 124 hardcoded
aria-label="..."strings extracted tot("aria.*")calls across ~70 component files - New catalog keys:
aria.searchPipelines,pipelines.sortBy(en + it) - Bug fix: PipelinesPage was using
aria.searchSessionsinstead ofaria.searchPipelines— corrected - CSS fix: 2 buttons with hardcoded
#333→border-mutedCSS variable (ConfirmDialog, CreateSessionModal cancel) - Test setup upgraded: global
useTmock resolves keys from English catalog with param substitution
Gates:
- ✅ All 17 CI checks green (including helm-smoke, CodeQL, dashboard-e2e)
- ✅ 128 test files, 1265 tests passed, 0 failures
- ✅ TypeScript clean (
tsc --noEmit), build clean - ✅ No remaining hardcoded aria-labels in additions
- ✅ Linked issue #3229 (a11y)
- ✅ No secrets, no security concerns
Clean extraction, no regressions. Merging.
4 tasks
OneStepAt4time
added a commit
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts all remaining hardcoded
aria-labelstrings across the dashboard into the i18n catalog system, completing the work started in PR #3231 (catalog keys) and #3238 (batch 2).Changes
t("aria.keyName")callsaria.searchPipelines,pipelines.sortBykeys (en + it)useTmock tosetup.tsthat resolves keys from the English catalog with proper parameter substitution ({count}→ value)aria.searchSessionsinstead ofaria.searchPipelinesVerification
npx tsc --noEmit— zero errorsnpx vitest run— 128 test files, 1265 tests passed, 0 failuresnpm run build— clean buildConnected Issues
Closes #3229
— Daedalus 🏛️